[release/11.0] [ci-fix] Mark Apple test runner LibraryImports safe (refs #134061) - #134326
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…134134) Fixes the Apple NativeAOT test-runner build under the updated memory-safety rules by marking the two `LibraryImport` declarations `safe`. The native entry points synchronously copy the marshalled UTF-8 input into `NSString` and do not retain, mutate, or perform pointer operations on the caller's buffer. Marking the declarations `unsafe` removed `SYSLIB1064` but introduced `CS9362` at all four ordinary call sites. Validated with the exact iOS-simulator reproducer and the targeted repository build using `Features=updated-memory-safety-rules`; both completed with zero warnings and zero errors. A full local Apple NativeAOT build is not available because the installed Xcode rejects the repository's iOS 13 deployment target before managed compilation. Refs #134061 > [!NOTE] > This pull request description was updated with GitHub Copilot. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Vitek Karas <10670590+vitek-karas@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
Member
|
/azp run runtime-extra-platforms |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
davidnguyen-tech
approved these changes
Sep 21, 2026
Member
|
Thanks for backporting :) |
matouskozak
approved these changes
Sep 21, 2026
This was referenced Sep 21, 2026
Open
Member
|
there are still a few "unsafe" errors in the nativeaot build |
Member
There is another parallel PR to this which will need to be backported #134212 |
steveisok
added
Servicing-approved
steveisok
approved these changes
Sep 21, 2026
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #134134 to release/11.0
11.0 version of a fix for #134061
/cc @vitek-karas @github-actions[bot]
Customer Impact
This is a test-only change to adapt tests to the new unsafe/safe rules enabled on the repo.
Regression
#134061
Testing
This is a build break in extra-platforms, so rerunning extra platforms in CI to validate the fix.
Risk
Low - test-only fix.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.release/X.0(no-stagingsuffix).Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.